Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of output directory in packaging mojo for bundles with nested jars #2859

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix creation of output directory in packaging mojo for bundles with nested jars #2859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tycho-packaging-plugin/src/main/java/org/eclipse/tycho/packaging/PackagePluginMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,11 @@ private File makeJar(BuildOutputJar jar) throws MojoExecutionException {
File jarFile = new File(project.getBasedir(), jarName);
JarArchiver archiver = new JarArchiver();
archiver.setDestFile(jarFile);
archiver.addDirectory(jar.getOutputDirectory());
File outputDirectory = jar.getOutputDirectory();
if (!outputDirectory.mkdirs() && !outputDirectory.exists()) {
throw new IOException("creating output directory " + outputDirectory.getAbsolutePath() + " failed");
}
archiver.addDirectory(outputDirectory);
if (customManifest != null) {
for (File sourceFolder : jar.getSourceFolders()) {
File manifestFile = new File(sourceFolder, customManifest);
Expand Down
Loading