-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example to reproduce #1261 #1273
Conversation
@mickaelistria can you help converting this into a integration test? |
I don't think I'll spend time to make it an automated test, particularly since it requires to setup gpg on the CI and so on, it's more work than what I'm able to spend these days. The other PR is relatively safe and this part of the code is not too fragile, so we can live without a test for the moment. |
@Kummallinen thanks for the test do you like to investigate if a temporary key can be generated and used for the test? |
I can look into it but won't have the time for a few weeks. From my experiences using the gig plugin in my own builds I think getting the temporary key into a usable key ring would be the sticking point. |
2bb18ff
to
9088438
Compare
I think @merks has already done some tests with temporary PGP key, maybe the aproach can be reused/adapted for a test here? |
9088438
to
4976111
Compare
Closing as no further feedback from original author @Kummallinen if this is still interesting for you please let me know so we can reopen the PR. |
Example p2 repo which reproduces #1261, requested in PR #1268
Building this repo requires an environment already set up to PGP sign artifacts, the key name & password server ID need to be passed via the test-pgp-key.name & test-pgp-key.serverId properties.