Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example to reproduce #1261 #1273

Closed

Conversation

Kummallinen
Copy link
Contributor

Example p2 repo which reproduces #1261, requested in PR #1268

Building this repo requires an environment already set up to PGP sign artifacts, the key name & password server ID need to be passed via the test-pgp-key.name & test-pgp-key.serverId properties.

@laeubi
Copy link
Member

laeubi commented Aug 16, 2022

@mickaelistria can you help converting this into a integration test?

@laeubi laeubi requested a review from akurtakov August 16, 2022 14:52
@mickaelistria
Copy link
Contributor

I don't think I'll spend time to make it an automated test, particularly since it requires to setup gpg on the CI and so on, it's more work than what I'm able to spend these days. The other PR is relatively safe and this part of the code is not too fragile, so we can live without a test for the moment.
If someone feels like they can make it an automated test, please do it; if not, please close this PR.

@laeubi laeubi marked this pull request as draft August 28, 2022 10:13
@laeubi
Copy link
Member

laeubi commented Sep 8, 2022

@Kummallinen thanks for the test do you like to investigate if a temporary key can be generated and used for the test?

@Kummallinen
Copy link
Contributor Author

@Kummallinen thanks for the test do you like to investigate if a temporary key can be generated and used for the test?

I can look into it but won't have the time for a few weeks. From my experiences using the gig plugin in my own builds I think getting the temporary key into a usable key ring would be the sticking point.

@laeubi laeubi added this to the 3.1 milestone Sep 16, 2022
@laeubi laeubi modified the milestones: 3.1, 4.0 Oct 19, 2022
@laeubi laeubi force-pushed the issue_1261_reproducer branch from 2bb18ff to 9088438 Compare May 18, 2023 04:28
@laeubi
Copy link
Member

laeubi commented May 18, 2023

I think @merks has already done some tests with temporary PGP key, maybe the aproach can be reused/adapted for a test here?
@Kummallinen do you like to finish this PR so we can include it in the regular checks?

@github-actions
Copy link

github-actions bot commented May 18, 2023

Test Results

  579 files  ±0    579 suites  ±0   3h 51m 58s ⏱️ + 12m 14s
  392 tests ±0    385 ✅ +2   7 💤 ±0  0 ❌  - 2 
1 176 runs  ±0  1 154 ✅ +3  22 💤 ±0  0 ❌  - 3 

Results for commit 4976111. ± Comparison against base commit e28d416.

♻️ This comment has been updated with latest results.

@laeubi laeubi removed this from the 4.0 milestone May 31, 2023
@laeubi laeubi force-pushed the issue_1261_reproducer branch from 9088438 to 4976111 Compare January 23, 2024 05:33
@laeubi
Copy link
Member

laeubi commented May 5, 2024

Closing as no further feedback from original author @Kummallinen if this is still interesting for you please let me know so we can reopen the PR.

@laeubi laeubi closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants