-
Notifications
You must be signed in to change notification settings - Fork 194
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fail on missing plugin product requirement
Currently Tycho does not fail if a requirement of a product can't be found in the resolve phase but only if the product is materialized. Even then it fails with an obscure error that claims the products bundle is not found where actually the dependency can't be found.
- Loading branch information
Showing
18 changed files
with
434 additions
and
112 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 0 additions & 103 deletions
103
tycho-core/src/main/java/org/eclipse/tycho/p2/publisher/ProductDependenciesAction.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...s/projects/tycho-p2-director-plugin/missing-requirements-feature/feature/build.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ############################################################################### | ||
| # Copyright (c) 2010, 2011 SAP AG and others. | ||
| # All rights reserved. This program and the accompanying materials | ||
| # are made available under the terms of the Eclipse Public License v1.0 | ||
| # which accompanies this distribution, and is available at | ||
| # https://www.eclipse.org/legal/epl-v10.html | ||
| # | ||
| # Contributors: | ||
| # SAP AG - initial API and implementation | ||
| ############################################################################### | ||
| bin.includes = feature.xml |
30 changes: 30 additions & 0 deletions
30
tycho-its/projects/tycho-p2-director-plugin/missing-requirements-feature/feature/feature.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <feature | ||
| id="org.osgi.service.jaxrs.feature" | ||
| label="Example Feature" | ||
| version="1.0.0.qualifier"> | ||
|
|
||
| <description url="http://www.example.com/description"> | ||
| A description of an example feature | ||
| </description> | ||
|
|
||
| <copyright url="http://www.example.com/copyright"> | ||
| [Enter Copyright Description here.] | ||
| </copyright> | ||
|
|
||
| <license url="http://www.example.com/license"> | ||
| [Enter License Description here.] | ||
| </license> | ||
|
|
||
| <!-- this should not lead to an NPE in the dependency-only publisher (TYCHO-556) --> | ||
| <url> | ||
| <discovery label="New discovery site" url="http://newsite"/> | ||
| </url> | ||
|
|
||
| <plugin | ||
| id="org.osgi.service.jaxrs" | ||
| download-size="0" | ||
| install-size="0" | ||
| version="0.0.0"/> | ||
|
|
||
| </feature> |
50 changes: 50 additions & 0 deletions
50
tycho-its/projects/tycho-p2-director-plugin/missing-requirements-feature/feature/pom.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>tycho-its</groupId> | ||
| <artifactId>missing.parent</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>org.osgi.service.jaxrs.feature</artifactId> | ||
| <packaging>eclipse-feature</packaging> | ||
| <name>Example Feature</name> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.osgi</groupId> | ||
| <artifactId>org.osgi.service.jaxrs</artifactId> | ||
| <version>1.0.1</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.aries.spec</groupId> | ||
| <artifactId>org.apache.aries.javax.jax.rs-api</artifactId> | ||
| <version>1.0.4</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <version>2.3.1</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>jakarta.activation</groupId> | ||
| <artifactId>jakarta.activation-api</artifactId> | ||
| <version>1.2.2</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.eclipse.platform</groupId> | ||
| <artifactId>org.eclipse.osgi</artifactId> | ||
| <version>3.18.600</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> | ||
|
|
29 changes: 29 additions & 0 deletions
29
tycho-its/projects/tycho-p2-director-plugin/missing-requirements-feature/pom.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>tycho-its</groupId> | ||
| <artifactId>missing.parent</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> | ||
|
|
||
| <modules> | ||
| <module>feature</module> | ||
| <module>product</module> | ||
| </modules> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.tycho</groupId> | ||
| <artifactId>tycho-maven-plugin</artifactId> | ||
| <version>${tycho-version}</version> | ||
| <extensions>true</extensions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> |
10 changes: 10 additions & 0 deletions
10
...ts/projects/tycho-p2-director-plugin/missing-requirements-feature/product/feature.product
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <?pde version="3.5"?> | ||
|
|
||
| <product uid="plugin.product" version="1.0.0.qualifier" useFeatures="true" includeLaunchers="false" autoIncludeRequirements="false"> | ||
|
|
||
| <features> | ||
| <feature id="org.osgi.service.jaxrs.feature" /> | ||
| </features> | ||
|
|
||
| </product> |
Oops, something went wrong.