Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change README.md Azure RTOS -> Eclipse ThreadX #359

Closed

Conversation

MatthewKhouzam
Copy link

PR checklist

This is a documentation patch only. It does not affect the image here.

https://github.com/eclipse-threadx/threadx/raw/master/docs/threadx-features.png

  • Updated function header with a short description and version number
  • Added test case for bug fix or new feature
  • Validated on real hardware

Copy link
Contributor

@wickste wickste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution Matthew! I will update the image and some of links in a separate change shortly.

@MatthewKhouzam
Copy link
Author

MatthewKhouzam commented Feb 22, 2024

So... anything else to do? Basically I cannot merge the PR, it's up to the committers. ;)


We also provide [getting started guide](https://github.com/eclipse-threadx/getting-started) and [samples](https://github.com/eclipse-threadx/samples) using hero development boards from semiconductors you can build and test with.

See [Overview of Azure RTOS ThreadX](https://learn.microsoft.com/en-us/azure/rtos/threadx/overview-threadx) for the high-level overview, and all documentation and APIs can be found in: [Azure RTOS ThreadX documentation](https://learn.microsoft.com/en-us/azure/rtos/threadx/).
See [Overview of ThreadX](https://learn.microsoft.com/en-us/azure/rtos/threadx/overview-threadx) for the high-level overview, and all documentation and APIs can be found in: [ThreadX documentation](https://learn.microsoft.com/en-us/azure/rtos/threadx/).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hyperlink would not be proper since it is referred to Azure RTOS ThreadX instead of Eclipse ThreadX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jserv this has already been addressed in the latest version of the readme.md

@wickste
Copy link
Contributor

wickste commented Feb 22, 2024

So... anything else to do? Basically I cannot merge the PR, it's up to the committers. ;)

@MatthewKhouzam I have already updated all readmes, links, images, etc. in all repos in the ThreadX organization. Please take a look if you see anything missing.

@MatthewKhouzam
Copy link
Author

LGTM, so I will abandon the patch then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants