-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3763] Split the SelectionDialogDescription to prepare the Tree support #3857
Conversation
b3152b3
to
db4c87f
Compare
7c026f5
to
ce47cea
Compare
af8ac8a
to
c59f3a4
Compare
packages/view/backend/sirius-components-view-diagram-edit/src/main/resources/plugin.properties
Outdated
Show resolved
Hide resolved
dd123a8
to
251994c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the code looks good, I'll rebase it and fix the tiny issues detected here and there (it should mostly be conflicts with master)
...articipants/SelectionDialogDescriptionSelectionCandidatesExpressionMigrationParticipant.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/sirius/web/services/diagrams/ModelOperationDiagramDescriptionProvider.java
Outdated
Show resolved
Hide resolved
.../eclipse/sirius/components/view/builder/generated/SelectionDialogTreeDescriptionBuilder.java
Show resolved
Hide resolved
.../main/java/org/eclipse/sirius/components/view/builder/generated/diagram/DiagramBuilders.java
Show resolved
Hide resolved
...ipse/sirius/components/view/builder/generated/diagram/SelectionDialogDescriptionBuilder.java
Show resolved
Hide resolved
.../sirius/components/view/builder/generated/diagram/SelectionDialogTreeDescriptionBuilder.java
Show resolved
Hide resolved
...dit/src/main/java/org/eclipse/sirius/components/view/diagram/provider/DiagramEditPlugin.java
Outdated
Show resolved
Hide resolved
|
||
@Override | ||
public void postObjectLoading(EObject eObject, JsonObject jsonObject) { | ||
if (eObject instanceof SelectionDialogDescription selectionDialogDescription) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use a flatMap somewhere?
The SelectionDialogDescription will now just hold the message information The SelectionDialogDescription will now have a selectionDialogTreeDescription to make it possible for the specifier to display the selectable elements as a tree. The selectionDialogTreeDescription will be relatively simple at first time. Bug: #3763 Signed-off-by: Florian Barbin <[email protected]>
251994c
to
eb4c34b
Compare
I'll wait for the build and merge it |
The SelectionDialogDescription will now just hold the message information
The SelectionDialogDescription will now have a
selectionDialogTreeDescription to make it possible for the specifier to display the selectable elements as a tree.
The selectionDialogTreeDescription will be relatively simple at first time.
Bug: #3763
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
The current SelectionDialog behavior is still the same.