[3604] Make node overlap resolution faster during "Arrange All" #3635
+43
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the following diagram (a simple diagram with recursive nodes for every
papaya::NamedElement
, created on the "Package java.lang" element in the "Sirius Web" Papaya example), I go from 60s to a little less than 20s.Note that the first 6s or 7s seem to be spent in ELK? At least during this time I see the loading indicator added in #3574 spinning for these first seconds, and then it stops moving while my CPU is working for the rest of the duration.
The diagram is very specific and does not contain any actual overlap, so it's very possible my changes breaks some stuff. Take with a grain of salt for the moment.