PR to Fix 396 wrong border node creation location #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2024
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
from
8a65d0e to
441bc92
Compare
lredor
force-pushed
the
lre/bug/396-wrongBorderNodeCreationLocation
branch
2 times, most recently
from
8289b1d to
a38b17a
Compare
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
from
441bc92 to
add67ae
Compare
lredor
force-pushed
the
lre/bug/396-wrongBorderNodeCreationLocation
branch
from
a38b17a to
00dc7d3
Compare
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
from
add67ae to
3e2cd62
Compare
Remove parameter in private method that is always true.
Code has leftovers after some refactoring.
- Constructors of CreationUtil have been improved to directly have LayoutData as parameter instead of location and size. Indeed, the location is relative to the parent edit part and for border nodes, the parent edit part is not systematically the "host" of the called policy. - In NodeCreationEditPolicy, in case of border nodes, the "host edit part" is not systematically considered (to compute the RootLayoutData for example). The correct edit part, a parent of the host, is computed according to the mapping defined in the used tool. Bug: #396
lredor
force-pushed
the
lre/bug/396-wrongBorderNodeCreationLocation
branch
from
00dc7d3 to
ec2c328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.