[359] New implementation of move with arrow keys #360
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
lredor
force-pushed
the
bug/lre/359-moveFromKeyboard
branch
4 times, most recently
from
fb7d07d to
0555db3
Compare
lredor
force-pushed
the
bug/lre/359-moveFromKeyboard
branch
2 times, most recently
from
06dc15e to
6f99363
Compare
There was a problem hiding this comment.
If the mouse cursor leave the diagram frame during the "arrow key movement" (i.e. the node is selected, the arrow key is pressed and we can see the "helper result ghost" (the grey rectangle indicates where the element will be moved if the key is released)), the movement starts again from its point of departure. See attached video 2024-04-26 15-44-28.zip (inside zip file)
....ui/src-diag/org/eclipse/sirius/diagram/ui/tools/internal/palette/SiriusSelectionToolEx.java
Outdated
Show resolved
Hide resolved
.../src-diag/org/eclipse/sirius/diagram/ui/tools/internal/ui/SnapToAllDragEditPartsTracker.java
Show resolved
Hide resolved
This commit only updates the data used by SnapAllShapesTest without any change (except the migration).
The test org.eclipse.sirius.tests.swtbot.SnapAllShapesTest.testMoveBorderNodeOnNodeInContainer() has been updated. It wrongly used the same border nodes as "testMoveBorderNodeOnBorderNode()". This case has been detected because the new test class MoveAllShapesWithArrowKeysTest is inspired by this one.
This commit changes the CheckBoundsCondition to also be able to consider the HandleBounds figure and the scrollbars. A rounding problem has been detected in GraphicalHelper and fixed during these tests. Bug: #359
This commit disables the snap to the perpendicular axis of the arrow direction. Indeed, if the user moves a node in the left direction, for example, it doesn't want to see its node moves up or down too. The tests have also been adapted. Bug: #359
lredor
force-pushed
the
bug/lre/359-moveFromKeyboard
branch
from
6f99363 to
3ed7653
Compare
Good catch! I'll add specific code in org.eclipse.sirius.diagram.ui.tools.internal.palette.SiriusSelectionToolEx.handleViewerExited() to handle this case in the next PR version. |
Bug: #359