Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Guava usage (again) #358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reduce Guava usage (again) #358

wants to merge 4 commits into from
+381 −504

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Apr 13, 2024

  • [146] Remove Guava dependency in oes.common
  • [146] Remove Guava dependency in oes.ecore.extender
  • [146] Remove usage of com.google.common.base.Objects
  • [146] Remove Guava dependency in oes.editor.diagram

@pcdavid pcdavid added this to the v8.0.0 milestone Apr 13, 2024
@pcdavid
Copy link
Member Author

pcdavid commented Apr 13, 2024

This is not to be merged for now. Not for 7.4.1, probably not for 7.4.2 either.

@pcdavid pcdavid force-pushed the pcd/enh/guava branch 2 times, most recently from 5247774 to 5f5e1db Compare April 16, 2024 15:31
@pcdavid pcdavid force-pushed the pcd/enh/guava branch 2 times, most recently from 63639fc to f6d9365 Compare July 26, 2024 08:02
GlennPlou
GlennPlou requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@GlennPlou GlennPlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, otherwise it's OK

...rius.common/src/org/eclipse/sirius/common/tools/internal/interpreter/PolymorphicService.java Outdated Show resolved Hide resolved
...rg/eclipse/sirius/diagram/sequence/business/internal/operation/SetMessageRangeOperation.java Outdated Show resolved Hide resolved
...rg/eclipse/sirius/diagram/sequence/business/internal/operation/SetMessageRangeOperation.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GlennPlou GlennPlou GlennPlou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next major
Development

Successfully merging this pull request may close these issues.
2 participants
@pcdavid @GlennPlou