Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to AQL 8.0.x #2

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to AQL 8.0.x #2

wants to merge 1 commit into from
+16 −12

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Jul 4, 2023

Change-Id: I9c6ce4e1202bdeff65d159dd13c60f921294caaf
Signed-off-by: Pierre-Charles David [email protected]

@pcdavid pcdavid force-pushed the pcd/enh/aql-8.0 branch from e402aff to 2fb1c6e Compare July 4, 2023 09:03
ylussaud
ylussaud approved these changes Jul 4, 2023
View reviewed changes
Copy link

@ylussaud ylussaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work fine.

@pcdavid pcdavid added type: enhancement Making an existing feature better component: core labels Jul 4, 2023
@pcdavid
Copy link
Member Author

pcdavid commented Jul 4, 2023 •
edited
Loading

I think the code is OK, but:

  • tests have not been run yet;
  • the PR currently only changes the canary TP, so merging the code would break the build for all the others.
  • AQL 8.0 has not yet been officially released, and we can not depend on snapshots/milestones for an actual Sirius Desktop release.

@pcdavid pcdavid marked this pull request as draft January 9, 2024 08:34
@pcdavid
Switch to AQL 8.0.x
8548de6 
Change-Id: I9c6ce4e1202bdeff65d159dd13c60f921294caaf
Signed-off-by: Pierre-Charles David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylussaud ylussaud ylussaud approved these changes

Assignees
No one assigned
Labels
component: core type: enhancement Making an existing feature better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcdavid @ylussaud