[cleanup] Remove dead or redundant code for LayoutData

Code has leftovers after some refactoring.

plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/business/internal/view/LayoutData.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2009, 2021 THALES GLOBAL SERVICES and others.
+ * Copyright (c) 2009, 2024 THALES GLOBAL SERVICES and others.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
  * which accompanies this distribution, and is available at
@@ -215,7 +215,7 @@ public List<LayoutData> getChildren() {
     }
 
     /**
-     * Search recursively in in all the LayoutData is there is one which have
+     * Search recursively in in all the LayoutData if there is one which have
      * the element for target.
      * 
      * @param node

plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/business/internal/view/RootLayoutData.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2009, 2021 THALES GLOBAL SERVICES and others.
+ * Copyright (c) 2009, 2024 THALES GLOBAL SERVICES and others.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
  * which accompanies this distribution, and is available at
@@ -57,16 +57,7 @@ public class RootLayoutData extends LayoutData {
      *            the future size
      */
     public RootLayoutData(final EditPart editPart, final Point location, final Dimension size) {
-        final Object adaptObject = EditPartTools.getParentOfType(editPart, IGraphicalEditPart.class).resolveSemanticElement();
-        if (adaptObject instanceof AbstractDNode) {
-            init((AbstractDNode) adaptObject, location, size);
-        } else if (adaptObject instanceof DDiagram) {
-            init((DDiagram) adaptObject, location, size);
-        } else if (adaptObject instanceof DEdge) {
-            init((DEdge) adaptObject, location, size);
-        } else {
-            AbstractSiriusFormatDataManager.logUnhandledDiagramElementKindMessage(adaptObject);
-        }
+        this(EditPartTools.getParentOfType(editPart, IGraphicalEditPart.class).resolveSemanticElement(), location, size);
     }
 
     /**
@@ -107,12 +98,10 @@ public RootLayoutData(final AbstractDNode target, final ShapeEditPart editPart,
      */
     public RootLayoutData(final Object adaptObject, final Point location, final Dimension size) {
         super();
-        if (adaptObject instanceof AbstractDNode) {
-            init((AbstractDNode) adaptObject, location, size);
-        } else if (adaptObject instanceof DDiagram) {
-            init((DDiagram) adaptObject, location, size);
-        } else if (adaptObject instanceof DEdge) {
-            init((DEdge) adaptObject, location, size);
+        if (adaptObject instanceof DDiagram // for root
+                || adaptObject instanceof AbstractDNode // container or simple node
+                || adaptObject instanceof DEdge) {
+            init((EObject) adaptObject, location, size);
         } else {
             AbstractSiriusFormatDataManager.logUnhandledDiagramElementKindMessage(adaptObject);
         }
@@ -170,8 +159,10 @@ public RootLayoutData getRoot() {
     }
 
     /**
-     * Search recursively in in all the DiagramLayoutData is there is one which
-     * have the diagram for target.
+     * Search if there is data which have the diagram for target.
+     * <p>
+     * Default implementation does not perform a recursive search.
+     * </p>
      * 
      * @param diagram
      *            The search diagram