GH-5208 Enable request tracing through logs using new associated request id #5209
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sociated request id
hmottestad
reviewed
Nov 26, 2024
| private volatile String origThreadName; | ||
|
|
||
| @Override | ||
| public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler) | ||
| throws Exception { | ||
| origThreadName = Thread.currentThread().getName(); | ||
| Thread.currentThread().setName(getThreadName()); | ||
| MDC.put(REQUEST_ID, UUID.randomUUID().toString()); |
There was a problem hiding this comment.
I've also used MDC for this in other dev projects. It's probably still the best option.
From experience it can get quite expensive to generate a lot of UUIDs especially if the transactions are very small. Can we have the UUID as a string at startup and then an AtomicLong that we increment and append?
There was a problem hiding this comment.
Good point! Should be changed. Introduced a process UUID which is postpended with an AtomicLong in a format which should be parsable by some tooling if need be.
Let me know your thoughts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5208
Briefly describe the changes proposed in this PR:
This PR adds a unique request identifier to MDC in order to allow for more intelligent log parsing and aggregation as well as aid in server debugging.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)