GH-4950 LMDB: extensible ID scheme #4956
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenwenzel
force-pushed
the
GH-4950-lmdb-extensible-ids
branch
from
474eadf
to
6fd1d40
Compare
|
The failing integration tests: It's a test that is marked as disabled, but has somehow started to run again. Not sure how that happened. |
Implement an extensible ID scheme for the LmdbStore that also allows to embed values into IDs.
kenwenzel
force-pushed
the
GH-4950-lmdb-extensible-ids
branch
from
6fd1d40
to
a53aae5
Compare
|
@hmottestad It would be good to have this in 5.0.0 as it is a breaking change but I am not sure if I can finish the whole logic. |
|
Sorry. I've already published the M3 milestone build and we now have a feature freeze until the final release. The LMDB Store is experimental, so you should be able to make breaking changes for 5.1.0. Might be better too, since then users can upgrade to 5.0.0 and get all the fixes and enhancements without any major breaking changes. |
|
PS: The develop branch is now 5.1.0 so you can merge into the develop branch without affecting the 5.0.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement an extensible ID scheme for the LmdbStore that also allows to embed values into IDs.
GitHub issue resolved: #4950
Briefly describe the changes proposed in this PR:
Use a binary encoding for IDs that allows to represent the value type, if the value itself is embedded within the id and the embedded value itself.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)