GH-4544 Openrewrite changes to the test classes.

[JervenBolleman]

A few reverts regarding pom changes.

GitHub issue resolved: #4544

Briefly describe the changes proposed in this PR:

Just seeing what openrewrite does regarding junit4 to junit5, as well as what they consider best practice.

---

PR Author Checklist (see the contributor guidelines for more details):

• my pull request is self-contained
• I've added tests for the changes I made
• I've applied code formatting (you can use mvn process-resources to format from the command line)
• I've squashed my commits where necessary
• every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

[erikgb]

The diff is huge! Would it be possible to split this change - to make it reviewable? Most of the changes seem to be related to improving Java access modifiers.

[JervenBolleman]

I have been experimenting with openrewrite to see if I can make it not do this public access removal but have not yet succeeded.

Converting it to draft in the meantime, looks like it will be easier to rerun the rewrite than do the rebase.

[JervenBolleman]

using

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE
-Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.AddMissingNested

and to check the diferences in java code.

git diff -- ../$(git status --porcelain|grep '^ M'|head -n 1|cut -b 4-)

if there is public to package method changes undo these with

sed -i -e 's|\tvoid |\tpublic void |g' ../$(git status --porcelain|grep '^ M'|head -n 1|cut -b 4-)
# check nothing else changed
git diff -- ../$(git status --porcelain|grep '^ M'|head -n 1|cut -b 4-)

then add to the commit

git add -- ../$(git status --porcelain|grep '^ M'|head -n 1|cut -b 4-)

[JervenBolleman]

@erikgb I think it is best to wait with this until #4592 is merged as it kinda depends on that working nicely first. But thanks for already having a look.