GH-2998 possible improvement to the Changeset

eclipse-rdf4j · May 9, 2024 · 3dd4931 · 3dd4931
1 parent 610eed1
commit 3dd4931
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/core/sail/base/src/main/java/org/eclipse/rdf4j/sail/base/Changeset.java b/core/sail/base/src/main/java/org/eclipse/rdf4j/sail/base/Changeset.java
@@ -806,6 +806,21 @@ Iterable<Triple> getApprovedTriples(Resource subj, IRI pred, Value obj) {
 
 	void removeApproved(Statement next) {
 		assert !closed;
+
+		Model localApproved = approved;
+		if (localApproved != null && !localApproved.contains(next)) {
+			boolean readLock = readWriteLock.readLock();
+			try {
+				if (approved != null && !approvedEmpty) {
+					if (!approved.contains(next)) {
+						return;
+					}
+				}
+			} finally {
+				readWriteLock.unlockReader(readLock);
+			}
+		}
+
 		long writeLock = readWriteLock.writeLock();
 		try {
 			if (approved != null) {