Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ability to have pt in css for font sizes #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added ability to have pt in css for font sizes #238

wants to merge 1 commit into from

Conversation

fx-world
Copy link
Contributor

I have no idea why the commit is "mknauer authored", that was not the case.

Also-by: Ralf Schlesinger [email protected]
Also-by: Rico Scholz [email protected]

@eclipse-rap-bot
Copy link

Can one of the admins verify this patch?

@ifurnadjiev
Copy link
Contributor

ok to test

@ifurnadjiev
Copy link
Contributor

It's better to implement it in PropertyResolver.readFontSize(LexicalUnit) instead of PropertyResolver.readSingleLengthUnit.
PropertyResolver.readSingleLengthUnit is used in other places like readDimension or readShadow, where pt does not make sense. Please add a test to org.eclipse.rap.rwt.internal.theme.css.PropertyResolver_Test.testFontSize().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fx-world @eclipse-rap-bot @ifurnadjiev @mknauer