Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical layout of multi-port channels #29

Open
ajmooij opened this issue Mar 1, 2022 · 1 comment
Open

Graphical layout of multi-port channels #29

ajmooij opened this issue Mar 1, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@ajmooij
Copy link
Contributor

ajmooij commented Mar 1, 2022

Multi-port channels (i.e., channels that connect more than two ports) are graphically represented by a small black square node, and edges between the black square and each of the connected ports.

The default graphical layout is remarkable in multiple aspects:

  • Location of the black square
    • Sometimes around the middle of the connected ports (this seems to be the most logical)
    • Sometimes in the top-left corner
  • Edge routing
    • Usually unnecessarily complex

This applies to multiple scenarios that seem to behave differently:

  • Initializing a graphical view based on a textual model;
    system ports instances I1 : C I2 : C I3 : C channels { I1.P, I2.P, I3.P }
    cluster class C ports P instances channels
  • Creating a multi-port channel using the graphical editor;
  • Creating a multi-port channel in the textual editor when a graphical view has already been created (so by adding/removing the fragment {I1.P, I2.P, I3.P}).
@wpiers wpiers added the enhancement New feature or request label Nov 22, 2022
@wpiers wpiers added this to the 1.0.3 milestone Nov 22, 2022
wpiers added a commit that referenced this issue Nov 24, 2022
Change-Id: I9baf0c1dafeed2b1f1e5ca87dd0b97b4b5d4d9a1
@wpiers
Copy link
Contributor

wpiers commented Nov 24, 2022

6623bed adresses the "Usually unnecessarily complex" part of the issue, which was occuring when creating a multi-port channel.

The location of black squares should still be improved, as as previously stated they sometimes are in the top left corner. Also, ELK layout might be improved regarding those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants