Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a channel resets the previous layout of a channel #37

Closed
arnauddieumegard opened this issue Sep 15, 2022 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@arnauddieumegard
Copy link

Lets assume the following model:
image

If I create a new channel between Production.Control and folder.in then the layout becomes:
image

One may want the black square to stay at its previous location.

@wpiers wpiers added the bug Something isn't working label Nov 22, 2022
@wpiers wpiers added this to the 1.0.3 milestone Nov 22, 2022
@wpiers
Copy link
Contributor

wpiers commented Nov 23, 2022

"in" and "Control" ports are both already connected to several ports, thus have a black square each (a ChannelCluster). When you connect those two, the two channel clusters are merged. If the channel is created started from "in", the "in" channel cluster is kept, the other is deleted and its edges are reconnected to the "in" cluster. And the other way around.

So basically the square does not move, it is merged with another. The relayout of the channels previously connected to the deleted ChannelCluster give a wrong impression of what happens.

I will close this issue as the channel merging worked as intended but note that the layout of channel is already the subject of another issue, #29, so there are leads to improve the UX on this subject.

@wpiers wpiers closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants