-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show diff in "replace with local history" dialog on selection change #1625
show diff in "replace with local history" dialog on selection change #1625
Conversation
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
...undles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/ReplaceLocalHistory.java
Outdated
Show resolved
Hide resolved
Test Results 1 755 files ±0 1 755 suites ±0 1h 33m 1s ⏱️ + 4m 28s For more details on these failures, see this check. Results for commit 15e1afb. ± Comparison against base commit 3776c2f. ♻️ This comment has been updated with latest results. |
da92e2a
to
874a1d2
Compare
Issue was detected in an internal UX review. UX experts were asking us why the UI is not updated when an entry in the history list is selected. Question is absolutely valid from my point of view. |
925d2fd
to
1d3f284
Compare
Following code block is needed to fix layouting issue on macOS. See screencast below:
layouting_issue.mov |
701bcf2
to
245c371
Compare
...ndles/org.eclipse.team.ui/src/org/eclipse/team/ui/history/HistoryPageCompareEditorInput.java
Outdated
Show resolved
Hide resolved
245c371
to
5dbdad0
Compare
5dbdad0
to
a040bc7
Compare
62559d7
to
f093e2a
Compare
- disallow multi selection in "replace with local history" dialog - fix layouting issue on MacOS when loading the compare viewers on selection change
f093e2a
to
15e1afb
Compare
Failures are unrelated. Merging this. |
The "Replace With" -> "Local History ..." option in the source editor context menu launches a dialog that allows users to revert to a previous version. Initially, this dialog displays a list of all available revisions:
Previously, selecting an entry from the revision list did not trigger any action. Users had to double-click to view the differences.
This pull request enhances the behavior by displaying the differences upon a single click/selection.