[performance] IFile.create: reduce 1 of 3 store.fetchInfo() #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
Jun 25, 2024
| // under this location. | ||
| message = NLS.bind(Messages.resources_existsLocalDifferentCase, | ||
| IPath.fromOSString(store.toString()).removeLastSegments(1).append(name).toOSString()); | ||
| throw new ResourceException(IResourceStatus.CASE_VARIANT_EXISTS, getFullPath(), message, null); |
There was a problem hiding this comment.
If the error is no longer thrown it should be removed from the messages file(s) as well.
There was a problem hiding this comment.
what exactly do you think is unused now?
jukzi
force-pushed
the
File_create_no_exist_check
branch
from
c46b47a to
cdb68f5
Compare
|
rebased. expecting error for |
|
As expected error on windows only: |
Assume the file does not exist (normal case) - otherwise implementation fails later during actual write. eclipse-platform#1443
jukzi
force-pushed
the
File_create_no_exist_check
branch
from
cdb68f5 to
f779562
Compare
|
updated with fix for hidden files. |
|
if there are no objections i plan to merge tomorrow |
|
Similar remark as in #1446 (comment). |
Same reasoning as there: put a breakpoint in the catch clause and verify it never happens under normal conditions. It would only happen under the absurd conditions of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the file does not exist (normal case) - otherwise implementation fails later during actual write.
#1443