-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract ConfigurationSessionTest into separate plug-in #1333
Extract ConfigurationSessionTest into separate plug-in #1333
Conversation
The ConfigurationSessionTest introduces a many dependencies to the org.eclipse.core.tests.harness plug-in, as it has to define dependencies to everything that is part of the minimal bundle set for a ConfigurationSessionTest at runtime. The list of dependencies will become even larger when migration session tests to JUnit 5. In order to reduce the dependencies of org.eclipse.core.tests.harness to what is actually necessary for the plug-in's content, this change moves the ConfigurationSessionTest into a separate plug-in, so that only that plug-in has the according set of dependencies.
@HannesWell May I ask you what you think about the extraction of the The |
In general I have no objections, I only think that one extra plugin project only for that class is a bit heavy-weight. |
Thank you, @HannesWell! I agree that an extra plugin for a single class is quite heavy-weight. Unfortunately, the number of bundles added in |
I close this and simply add the explicit dependencies to the |
The ConfigurationSessionTest introduces a many dependencies to the org.eclipse.core.tests.harness plug-in, as it has to define dependencies to everything that is part of the minimal bundle set for a ConfigurationSessionTest at runtime. The list of dependencies will become even larger when migration session tests to JUnit 5.
In order to reduce the dependencies of org.eclipse.core.tests.harness to what is actually necessary for the plug-in's content, this change moves the ConfigurationSessionTest into a separate plug-in, so that only that plug-in has the according set of dependencies.
Preparation for #1086