Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to filter views by category #2579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptziegler
Copy link
Contributor

The ability to sort by categories was previously possible, but broke as part of 7275893. This seems to be unintentional, given that the linked bug [1] is about exposing the FilteredTree and likely a result of streamlining the implementation.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=74795

@ptziegler
Copy link
Contributor Author

ptziegler commented Dec 3, 2024

#2576

recording.webm

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From bed8c00116ea688a069377fce1b87ca99eaf2940 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 3 Dec 2024 17:45:00 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
index c15044ab33..ce84f6bee7 100644
--- a/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.swt;singleton:=true
-Bundle-Version: 0.17.600.qualifier
+Bundle-Version: 0.17.700.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

 1 214 files  + 1 214   1 214 suites  +1 214   1h 17m 5s ⏱️ + 1h 17m 5s
 7 726 tests + 7 726   7 493 ✅ + 7 493  231 💤 +231  2 ❌ +2 
16 226 runs  +16 226  15 711 ✅ +15 711  513 💤 +513  2 ❌ +2 

For more details on these failures, see this check.

Results for commit a95e6b0. ± Comparison against base commit ce9874f.

♻️ This comment has been updated with latest results.

The ability to sort by categories was previously possible, but broke as
part of 7275893. This seems to be
unintentional, given that the linked bug [1] is about exposing the
FilteredTree and likely a result of streamlining the implementation.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=74795
@vogella
Copy link
Contributor

vogella commented Dec 4, 2024

Nice and easy fix. Thanks @ptziegler. Looks like we have issues with either Tycho (cc @laeubi) or JDT (cc @iloveeclipse):

https://github.com/eclipse-platform/eclipse.platform.ui/actions/runs/12154551527/job/33894491261?pr=2579#step:7:75

Could not find artifact org.eclipse.jdt:ecj:jar:3.40.100-SNAPSHOT in eclipse-snapshots (https://repo.eclipse.org/content/repositories/eclipse-snapshots/)

@jukzi jukzi added enhancement New feature or request regression labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants