ToolItemUpdater: fix possible Integer overflow

[jukzi]

Both DELAY and 1_000_000 are Integers. Multiplied they could exceed max integer. Currently the DELAY is small enough to not overflow, but changing the constant would silently overflow.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 9eed3896fa14ac63afe69084e3ba78ae3ad46777 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 3 Dec 2024 13:10:51 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
index cc823104a9..2bef9ec5ed 100644
--- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.renderers.swt;singleton:=true
-Bundle-Version: 0.16.600.qualifier
+Bundle-Version: 0.16.700.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 214 files   -   607   1 214 suites   - 607   1h 14m 19s ⏱️ - 36m 29s
 7 726 tests ±    0   7 494 ✅  -     3  231 💤 +  3  1 ❌ ±0 
16 226 runs   - 8 113  15 712 ✅  - 7 879  513 💤  - 234  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit e018952. ± Comparison against base commit 98ff2aa.

This pull request skips 3 tests.

UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

[jukzi]

CI fails with unrelated errors that i do not understand
MavenProject: org.eclipse.platform:org.eclipse.ui.tests:3.15.1900-SNAPSHOT @ /home/jenkins/agent/workspace/eclipse.platform.ui_PR-2572/tests/org.eclipse.ui.tests/.polyglot.META-INF: baseline and build artifacts have same version but different contents
@akurtakov any idea?