Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change classes with shortcut #2523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change classes with shortcut #2523

wants to merge 1 commit into from

Conversation

jannisCode
Copy link
Contributor

This is a new PR which continues #2413 which got accidentally closed.

@jannisCode jannisCode force-pushed the tab_change branch 3 times, most recently from f16f503 to ecd36ed Compare November 19, 2024 11:45
@jannisCode jannisCode changed the title Change classes with shortcut #2413 Change classes with shortcut Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 49m 6s ⏱️ - 1m 42s
 7 726 tests ±0   7 498 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 339 runs  ±0  23 592 ✅ +1  747 💤 ±0  0 ❌  - 1 

Results for commit 9491460. ± Comparison against base commit 98ff2aa.

♻️ This comment has been updated with latest results.

@jannisCode jannisCode marked this pull request as ready for review November 19, 2024 14:32
@jannisCode jannisCode force-pushed the tab_change branch 2 times, most recently from d478459 to 7b53e93 Compare November 19, 2024 14:53
Wittmaxi
Wittmaxi approved these changes Nov 23, 2024
View reviewed changes
Copy link

@Wittmaxi Wittmaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses my last issues - especially about the parts which can be improved by using Array stream operations. The naming issue I had brought up is also adequately fixed, imo

...org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/handlers/TraversePageHandler.java
@@ -71,4 +119,4 @@ protected Method getMethodToExecute() {
return null;
}

}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: remove empty line in diff

@Wittmaxi
Copy link

random fail #1808

Let me know if I should merge this :)

@mickaelistria mickaelistria added this to the 4.35 M1 milestone Nov 24, 2024
@mickaelistria
Copy link
Contributor

The change seems fine to merge, but please wait for the announcement of next 4.35 stream being open on the eclipse-dev mailing-list.

@jannisCode jannisCode force-pushed the tab_change branch 2 times, most recently from b5860be to f29e611 Compare November 25, 2024 09:35
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 37953af3ef5f81142a69821c8d8006f327123f27 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 25 Nov 2024 09:40:08 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
index b43589cf1f..c0d826a9b6 100644
--- a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true
-Bundle-Version: 3.134.0.qualifier
+Bundle-Version: 3.134.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.WorkbenchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@jannisCode
Copy link
Contributor Author

@Wittmaxi

Let me know if I should merge this :)

I think the freeze periond is over, so if you are ready and the changes seem fine, you could merge it i think : )

@jannisCode
Change classes with shortcut eclipse-platform#2413
9491460 
Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wittmaxi Wittmaxi Wittmaxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.35 M1
Development

Successfully merging this pull request may close these issues.
4 participants
@jannisCode @Wittmaxi @mickaelistria @eclipse-platform-bot