Fixes to issue #2313 Light (Preview) Theme #2485
Conversation
mai-tran-03
changed the title
|
getCustomThemeFlag was introduced with e60b130 which was a fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=506553 |
There was a problem hiding this comment.
I rebased your contribution on master locally, launched it, and ran a 'clean all the projects' installed (I imported all the platform ui projects in my workspace). it is working well with or without a theme and whatever the theme chosen for the 'building' progress...
Please give a good name to the method used even if the method is private.
| @@ -1014,7 +1016,7 @@ private boolean getCustomThemeFlag() { | |||
| if (engine != null) { | |||
| ITheme activeTheme = engine.getActiveTheme(); | |||
| if (activeTheme != null) { | |||
| return !DEFAULT_THEME.equals(activeTheme.getId()); | |||
| return DARK_THEME.equals(activeTheme.getId()); | |||
There was a problem hiding this comment.
the getCustomThemeFlag() says in the javadoc that it is returning true if a theme is selected. But the method returns true if the current theme is the dark one. even if this is a private method, it could be renamed into 'isDarkThemeSelected'
|
@BeckerWdf is this PR included in or superseded by #2549? |
no it's not. |
|
This PR does not touch the theme's css file at all. So it's not really related. |
Since the progress item background color is inconsistent in the light preview theme and is fine in other themes, I explicitly made
DARK_THEMEa custom theme so it would still have its color components while the background color is consistent in the light preview.Fixes #2313