Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up workflow for automated version increments in pull-requests #2326

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Sep 25, 2024

Set up for this repository the workflow for automated version increments in pull-requests added via eclipse-platform/eclipse.platform.releng.aggregator#2352

Before this can work complete, the EF infra team has to add the required PAT of the Platform-bot to this repo as described in the linked PR and requested in

Copy link
Contributor

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 36m 50s ⏱️ + 1m 13s
 7 699 tests ±0   7 471 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 258 runs  ±0  23 511 ✅ ±0  747 💤 ±0  0 ❌ ±0 

Results for commit dc31640. ± Comparison against base commit c603575.

@jukzi
Copy link
Contributor

jukzi commented Sep 26, 2024

It would be nice if this could be tested with significant PR before rolling it out to every repo.
With significant PR i mean something non trivial like

  • needs multiple versions bumps
  • not all needed version bumps are reported in the first build
  • as a result a feature needs to be updated.

@HannesWell
Copy link
Member Author

eclipse-pde/eclipse.pde#1413

It would be nice if this could be tested with significant PR before rolling it out to every repo.
With significant PR i mean something non trivial like

That has been done extensively and it worked well in:

and before that in my PDE fork:
https://github.com/HannesWell/eclipse.pde/pulls

Of course committers should still check the entire content of a PR as usual.

@HannesWell
Copy link
Member Author

The PAT has been added via eclipse-equinox/.eclipsefdn#1, so this is ready for submission.

For eclipse.platform I have already verified it works.

@HannesWell HannesWell merged commit f35ef3a into eclipse-platform:master Sep 26, 2024
17 checks passed
@HannesWell HannesWell deleted the set-up-version-increment-workflow branch September 26, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants