Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the JFace.action tests to Junit4 #1220

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Oct 13, 2023

Instead of inheriting TestCase these tests use now a JUnit rule for setup and teardown.

Instead of inheriting TestCase these tests use now a JUnit rule for
setup and teardown.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Test Results

     900 files  +     900       900 suites  +900   1h 56m 12s ⏱️ + 1h 56m 12s
  7 448 tests +  7 448    7 291 ✔️ +  7 291  156 💤 +156  1 +1 
23 490 runs  +23 490  22 974 ✔️ +22 974  515 💤 +515  1 +1 

For more details on these failures, see this check.

Results for commit ceb0297. ± Comparison against base commit 5f47dac.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for migrating to JUnit 4!
Checks only seem to be broken because of API tooling issue: eclipse-pde/eclipse.pde#782.

@vogella vogella merged commit 42ad517 into master Oct 17, 2023
1 check failed
@vogella
Copy link
Contributor Author

vogella commented Oct 17, 2023

Thanks @HeikoKlare

@vogella vogella deleted the unit-jface-actions-update-to-junit4 branch October 17, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants