Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test single letter increment of tag to fix build. #870

Conversation

the-snowwhite
Copy link
Contributor

No description provided.

found = true;
} else {
if (suffix === 'z') {
suffix = 'a'; // Reset to 'a' after 'z'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In existing code, if we've reached the case of 'z', it is most likely that the case of 'a' (i=97) and all other letters already reported that the suffix is already used.
You would basically want to write an algorithm that iterates through the sequences a..z,aa...az, ba...bz, ..., za...zz, aaa...aaz, aba...abz, ..., aza,...,azz, baa...baz and so on. It's a lot of smartness to put in a build scripts, particularly if we don't really need the tags.
Maybe just a timestamp suffix would be enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does github support numbers in suffixes ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git and GitHub don't have a concept of suffix, it's just some characters in the tag name; and yes, they do support numbers as characters in tag names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would'nt have this problem if the v4963r3 part of the tags were sure to be updated before 26 commits,
What mechanism updates this part or the tag ?

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Test Results

     299 files  ±0       299 suites  ±0   6m 41s ⏱️ +49s
  4 095 tests ±0    4 086 ✔️  - 1    8 💤 ±0  1 +1 
12 197 runs  ±0  12 123 ✔️  - 1  73 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit a713990. ± Comparison against base commit c7549d9.

@the-snowwhite
Copy link
Contributor Author

This is odd
this time around the swt matrix build failed but the jenkins build is still running (for almost 40 min).
These are bad signs...

@the-snowwhite the-snowwhite marked this pull request as draft November 9, 2023 10:49
@the-snowwhite
Copy link
Contributor Author

This build seems stuck.

@the-snowwhite the-snowwhite deleted the test_single_letter_tag_increment branch November 9, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants