-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test single letter increment of tag to fix build. #870
Test single letter increment of tag to fix build. #870
Conversation
found = true; | ||
} else { | ||
if (suffix === 'z') { | ||
suffix = 'a'; // Reset to 'a' after 'z' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In existing code, if we've reached the case of 'z', it is most likely that the case of 'a' (i=97
) and all other letters already reported that the suffix is already used.
You would basically want to write an algorithm that iterates through the sequences a..z,aa...az, ba...bz, ..., za...zz, aaa...aaz, aba...abz, ..., aza,...,azz, baa...baz and so on. It's a lot of smartness to put in a build scripts, particularly if we don't really need the tags.
Maybe just a timestamp suffix would be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does github support numbers in suffixes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git and GitHub don't have a concept of suffix, it's just some characters in the tag name; and yes, they do support numbers as characters in tag names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would'nt have this problem if the v4963r3 part of the tags were sure to be updated before 26 commits,
What mechanism updates this part or the tag ?
This is odd |
This build seems stuck. |
No description provided.