Multi zoom level path #1281
Merged
Multi zoom level path #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
multi_zoom_level_path
branch
2 times, most recently
from
7fc5742 to
6cb33ec
Compare
akoch-yatta
reviewed
Jun 17, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_path
branch
from
6cb33ec to
b9a0f95
Compare
akoch-yatta
reviewed
Jun 17, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_path
branch
2 times, most recently
from
ceaeb75 to
d0092c0
Compare
fedejeanne
requested changes
Jun 20, 2024
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/graphics/PathWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/graphics/PathWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/graphics/PathWin32Tests.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_path
branch
2 times, most recently
from
1a7c8fc to
764b27d
Compare
This commit contributes to the obtaining the path as per the zoom level of the monitor. A method win32_getPAth is used in place wherever path.handle was used earlier by the clients. The preferred zoom level has to be passed by the clients as a parameter to the mthod in order to get the handle for the scaled path. contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
multi_zoom_level_path
branch
from
764b27d to
5f9b058
Compare
fedejeanne
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues
Requires
Note: Only the last commit in this PR is to be reviewed. Previous commit(s) belong to the prerequisite PR(s)
Description
This pull request is based on the implementations of PR #1214. It extends to the native zoom which is provided within widget and propagated to GC. In this PR, the multiple zoom level functionality is attained by using a map to maintain the handle of the path scaled as per the zoom level. The handle can then be obtained by the method win32_getHandle by passing the zoom information from the client.
contributes to #62 and #127