[I/Y-Build] Simplify GPG-signing in I/Y-builds #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
simplify-gpg-signing
branch
from
b61c7d6 to
dcb1a42
Compare
Importing the secret-key is not necessary when signing with the bouncy-castle (BC) signer. Therefore just import the key where the gpg executable is used (i.e. when signing the list of artifact checksums).
HannesWell
force-pushed
the
simplify-gpg-signing
branch
from
dcb1a42 to
0444931
Compare
HannesWell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the secret-key is not necessary when signing with the bouncy-castle signer. Therefore just import the key where the
gpgexecutable is used (i.e. when signing the list of artifact checksums).Furthermore remove the explicit specification of the key used for gpg-signing and just use the first and only key available. This simplifies later updates of the key (avoids changes in the build).