Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux.riscv64 environment to eclipse-platform-parent and publish linux.riscv64 artifacts #2394

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Sep 26, 2024

@HannesWell HannesWell changed the title Publish linux.riscv64 Add win32.aarch64 environment to eclipse-platform-parent and publish win32.aarch64 artifacts Sep 26, 2024
@HannesWell HannesWell changed the title Add win32.aarch64 environment to eclipse-platform-parent and publish win32.aarch64 artifacts Add linux.riscv64 environment to eclipse-platform-parent and publish win32.aarch64 artifacts Sep 26, 2024
@HannesWell HannesWell force-pushed the publish-linux.riscv64 branch from f777d02 to 03dd35e Compare September 26, 2024 19:42
@HannesWell
Copy link
Member Author

@merks we also need something similar to #1953.
But when I add a <configurations operatingSystem="linux" windowSystem="gtk" architecture="riscv64"/> the Aggregator Editor cannot open the file anymore.
I'll therefore hold that off until we have support for riscv64 architectures. Can you tell if this has to be added explicitly or is this inherited at some point in time?

@yuzibo
Copy link

yuzibo commented Sep 27, 2024

@yuzibo FYI

Similiarly like it was done for Windows on ARM:

Part of #2310.

@yuzibo FYI

Thank you. I will add this to the summary list also.

merks added a commit to merks/eclipse.platform.releng.aggregator that referenced this pull request Sep 27, 2024
merks added a commit that referenced this pull request Sep 27, 2024
@merks
Copy link
Contributor

merks commented Sep 27, 2024

@HannesWell

I change to the *.aggr made the job fail:

#2397

The validation fails:

Cannot complete the install because one or more required items could not be found. Software being installed: validationSet_main 1.0.0 Missing requirement for filter properties ~= $0: org.eclipse.equinox.executable 3.8.2700.v20240924-2302 requires 'org.eclipse.equinox.p2.iu; org.eclipse.equinox.launcher.gtk.linux.riscv64 [1.2.1200.v20240924-2302,1.2.1200.v20240924-2302], filter=(&(osgi.arch=riscv64)(osgi.os=linux)(osgi.ws=gtk))' but it could not be found Cannot satisfy dependency: mappedRepo_download.eclipse.org_eclipse_updates_4.34-I-builds 1.0.0 depends on: org.eclipse.equinox.p2.iu; org.eclipse.equinox.executable 0.0.0 Cannot satisfy dependency: validationSet_main 1.0.0 depends on: org.eclipse.equinox.p2.iu; mappedRepo_download.eclipse.org_eclipse_updates_4.34-I-builds [1.0.0,1.0.0]
Missing requirement for filter properties ~= $0: Eclipse Platform Launcher Executables for Multi-Architecture Builds 3.8.2700.v20240924-2302 (org.eclipse.equinox.executable 3.8.2700.v20240924-2302) requires 'org.eclipse.equinox.p2.iu; org.eclipse.equinox.launcher.gtk.linux.riscv64 [1.2.1200.v20240924-2302,1.2.1200.v20240924-2302], filter=(&(osgi.arch=riscv64)(osgi.os=linux)(osgi.ws=gtk))' but it could not be found

InstallableUnit(org.eclipse.equinox.launcher.gtk.linux.riscv64 [1.2.1200.v20240924-2302,1.2.1200.v20240924-2302]) is required by:
  ValidationSet(main)
    Contribution(sdk_http)
      MappedRepository(https://download.eclipse.org/eclipse/updates/4.34-I-builds)
        InstallableUnit(org.eclipse.equinox.executable 3.8.2700.v20240924-2302)

I see this requirement in the IU org.eclipse.equinox.executable:

    <required namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.equinox.launcher.gtk.linux.riscv64' range='[1.2.1200.v20240924-2302,1.2.1200.v20240924-2302]'>
      <filter>
        (&amp;(osgi.arch=riscv64)(osgi.os=linux)(osgi.ws=gtk))
      </filter>
    </required>

How long do we think we'll be in this state where there a requirements that can't be satisfied? If that's a while, then I should revert that commit to the SDK4Mvn.aggr...

@HannesWell
Copy link
Member Author

How long do we think we'll be in this state where there a requirements that can't be satisfied? If that's a while, then I should revert that commit to the SDK4Mvn.aggr...

I hope it isn't long.
In general I believe we have the most difficult parts in place and just have to plugin in the missing pieces. I assume this to be a big one, but I first have to investigate why this is failing.

@HannesWell HannesWell changed the title Add linux.riscv64 environment to eclipse-platform-parent and publish win32.aarch64 artifacts Add linux.riscv64 environment to eclipse-platform-parent and publish linux.riscv64 artifacts Sep 29, 2024
@HannesWell HannesWell force-pushed the publish-linux.riscv64 branch from 03dd35e to ca67d8d Compare September 29, 2024 10:12
@HannesWell
Copy link
Member Author

HannesWell commented Sep 29, 2024

I have now investigated the failure in detail and found out that in the end the p2-baseline replacement removed the linux.riscv64 root-files in the o.e.equinox.executable.feature.
I have created eclipse-equinox/equinox#680 to fix that and explained it in detail there.
@yuzibo I have added the latter to #2310.

Temporarily I have changed the .gitmodules to build with eclipse-equinox/equinox#680 before it is submitted.

@HannesWell HannesWell marked this pull request as draft September 29, 2024 10:18
@HannesWell HannesWell force-pushed the publish-linux.riscv64 branch from ca67d8d to 4da01cd Compare September 29, 2024 11:46
@HannesWell HannesWell marked this pull request as ready for review September 29, 2024 11:46
@HannesWell
Copy link
Member Author

Testing was successful and this PR is now in it's final state.
After the build has succeeded, I'll submit this and want to start a new I-build immediately to verify everything works as expected.

@HannesWell HannesWell merged commit 29298ce into eclipse-platform:master Sep 29, 2024
4 checks passed
@HannesWell HannesWell deleted the publish-linux.riscv64 branch September 29, 2024 12:14
@HannesWell
Copy link
Member Author

@yuzibo
Copy link

yuzibo commented Sep 29, 2024

Thanks!

@HannesWell
Copy link
Member Author

Just started https://ci.eclipse.org/releng/job/Builds/job/I-build-4.34/50/.

This build succeeded and the org.eclipse.equinox.launcher.gtk.linux.riscv64 and org.eclipse.swt.gtk.linux.riscv64 fragments are now available in the corresponding I-build repository.
The new download links also all work as expected.

Thanks!

You're welcome. And thanks for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants