-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Builds] Remove elements unnecessary with the new version-bump workflow #2387
[Builds] Remove elements unnecessary with the new version-bump workflow #2387
Conversation
c45aafc
to
e8d34a8
Compare
As thenew workflow is not yet setup on this repo, this one can not be pushed, right? |
This repository is not really the problem since the removed elements are (hardly) used here, but we should await until it's active in all other (active) SDK repositories. And while JDT should only be a matter of committer time, Equinox and SWT seem to need more adjustments and might take longer. |
96dce5e
to
19abb15
Compare
With the new reusable workflow for automated version increments in pull-requests it is not necessary anymore to bump versions in advance during release preparation. This now happens automatically as part of the PR verification and that step can therefore be removed.
19abb15
to
8476eab
Compare
Landing this part in. |
To add some context, why this is important now:
With this being submitted, Equinox and SWT still don't get the version-bumps on first change in the dev-cycle, but at least changing the parent-pom version should be possible now. |
For Equinox and SWT the following PRs could now be created, after renaming the existing |
That workflow now just updates pom.xml files. Follow-up on eclipse-platform#2387
That workflow now just updates pom.xml files. Follow-up on eclipse-platform#2387
That workflow now just updates pom.xml files. Follow-up on #2387
With the new reusable workflow for automated version increments in pull-requests, introduced with #2352, it is not necessary anymore to bump versions in advance during release preparation or the enable bumping if the property 'compare-version-with-baselines.skip' is set to false. Everything now happens automatically and these elements can therefore be removed.
Removing these elements avoids partly duplicated configuration and generally reduced the amount of configuration.