Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update Comparator repo and eclipse run repo to 4.31-I-builds repo" #1595

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

MohananRahul
Copy link
Contributor

Reverts #1592 PR, Still we don't have stable build and will create PR again after stable build

@akurtakov
Copy link
Member

Push in order to try getting "good" 4.31 build.

@akurtakov akurtakov merged commit 8b7c70f into master Nov 28, 2023
3 of 4 checks passed
@akurtakov akurtakov deleted the revert-1592-CompVers branch November 28, 2023 06:22
@laeubi
Copy link
Contributor

laeubi commented Nov 28, 2023

Can someone please explain how this is supposed to work? I think I already asked last time but should the comparator repo not simply copied from last I builds to the new URL so we dont need to switch back and forth?

@akurtakov
Copy link
Member

There has to be a "good" I-build (aka without comparator issues) only in this case it is put in the stream p2 repo (https://download.eclipse.org/eclipse/updates/4.31-I-builds/). It should be done only once per stream after the first "good" I-build but it was done twice this time before the time has come that's why it has to be reverted twice.
All the scripts are way too complicated with a lot of hardcoding and etc. If someone spends the time I'm pretty sure that there is a room for a what of simplification.

@cdietrich
Copy link

the composite in https://download.eclipse.org/eclipse/updates/4.31-I-builds/ does not seem to be updated though

@merks
Copy link
Contributor

merks commented Nov 28, 2023

Yes, the dates look off:

And it's empty, other than categories:

image

@akurtakov
Copy link
Member

The add to composite stage failed https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/4/console . Note that is totally unrelated to the change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants