Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete white filter and empty groups in SVGs #110

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Michael5601
Copy link
Contributor

This PR fixes some icons related to the problems described in this issue issue.

I only deleted white filters and empty groups. Apparently empty groups in SVGs cause bugs when combined with SVG filter elements. I reported the issue to JSVG and it will soon be fixed. Until then we need to clean up the SVGs.

@BeckerWdf BeckerWdf merged commit ed55f78 into eclipse-platform:master Nov 22, 2024
3 checks passed
@BeckerWdf
Copy link
Contributor

Thanks for the fixes...

@Michael5601
Copy link
Contributor Author

Thanks for the fixes...

You're welcome! :)

@BeckerWdf
Copy link
Contributor

So with empty groups you mean something like this:

 <g
    id="g4990"
    transform="translate(-36.649179,0.40625)" />

How did you delete it? With a text editor or with Inkscape? If inksacpe: How can one do this there?

@Michael5601
Copy link
Contributor Author

So with empty groups you mean something like this:

 <g
    id="g4990"
    transform="translate(-36.649179,0.40625)" />

How did you delete it? With a text editor or with Inkscape? If inksacpe: How can one do this there?

yes exactly. I deleted them with Inkscape.
When you open the icon in inkscape you can see the layers and groups in the right window. Groups are represented as folders and you can just delete every empty folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants