Adjustment to icons for JSVG integration

[Michael5601]

To integrate vector graphics for icons in Eclipse, I analyzed various libraries that offer rasterization functionality. The analysis revealed that JSVG is the most suitable choice. While JSVG performs well for most Eclipse icons, some icons still require adjustments.

The list below provides an overview of these icons, grouped by similar issues with brief descriptions of the issues and example images. As some icons are duplicates the example image is shown for the last duplicate in the list but it also counts for the above icons. The original is on the left and the JSVG rasterization on the right. The blurr in the original icons is due to bad image quality and was discussed in issue:

Surrounding white filter:

• org.eclipse.debug.ui/icons/full/elcl16/pin.svg
• org.eclipse.ui.console/icons/full/clcl16/pin.svg
• org.eclipse.ui.console/icons/full/elcl16/pin.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newjprj_wiz.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newrecord_wiz.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newannotation_wiz.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newenum_wiz.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newpack_wiz.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newpackfolder_wiz.svg
  
• org.eclipse.jdt.ui/icons/full/etool16/newsbook_wiz.svg
  
• org.eclipse.ui.console/icons/full/elcl16/new_con.svg
• org.eclipse.ui.views/icons/full/elcl16/new.svg
• org.eclipse.ui/icons/full/etool16/new_wiz.svg
  

Unwanted white space:

• org.eclipse.debug.ui/icons/full/etool16/environment_co.svg
• org.eclipse.debug.ui/icons/full/obj16/environment_obj.svg
  
• org.eclipse.jdt.ui/icons/full/elcl16/hide_externalized.svg
  
• org.eclipse.jdt.ui/icons/full/elcl16/hide_ignored.svg
  
• org.eclipse.jdt.ui/icons/full/elcl16/hide_internalized.svg
  
• org.eclipse.ui.externaltools\icons\full\etool16\external_tools.svg
• eclipse.platform.common\bundles\org.eclipse.platform.doc.user\images\external_tools.svg
• org.eclipse.ui.externaltools\icons\full\obj16\external_tools.svg
  (Problems only seen in dark mode:)
  
  

Unwanted colored area:

• org.eclipse.equinox.p2.ui.admin/icons/obj/uninstalled_iu.svg
• org.eclipse.equinox.p2.ui.discovery/icons/obj16/iu_disabled_obj.svg
• org.eclipse.equinox.p2.ui/icons/obj/iu_disabled_obj.svg
  

Filter around numbers:

• org.eclipse.jdt.ui/icons/full/obj16/cf_src_test_obj.svg
  
• org.eclipse.jdt.ui/icons/full/obj16/cf_test_obj.svg
  

Full icon wrong color:

• org.eclipse.jdt.ui/icons/full/obj16/envvar_test_obj.svg
  

Bad text presentation:

• org.eclipse.team.ui/icons/full/obj/export_projectset.svg
  
• org.eclipse.team.ui/icons/full/obj/import_projectset.svg
  

Empty image:

• org.eclipse.ui.intro.universal/themes/solstice/graphics/launchbar/webresources16.svg
  

Edit:
All icons are fixed in #105. When opening the files in Inkscape it was clear that the rasterization result of JSVG was not wrong for almost all items. The results of JSVG were more similar to the icon in Inkscape than the reference PNGs.

[vogella]

@BeckerWdf please review

[BeckerWdf]

• org.eclipse.jdt.ui/icons/full/etool16/newjprj_wiz.svg
  

That "white"-ish area around the "star" was there by intention. It help to "separate" the star from the rest of the icon (this folder thingy). Why is it not visible on the left side? Is this the PNG we have in the images repo?

[Michael5601]

• org.eclipse.jdt.ui/icons/full/etool16/newjprj_wiz.svg
  

That "white"-ish area around the "star" was there by intention. It help to "separate" the star from the rest of the icon (this folder thingy). Why is it not visible on the left side? Is this the PNG we have in the images repo?

yes this is the icon from the images repo. It's the 32x32px PNG. This is not the only case where the white filter cannot be seen in the PNGs. The results of JSVG show the white filter so these results are in fact more correct.

In my opinion the white filter should be deleted as it looks like an error. I don't think there is a need to seperate the star from the background as the colors are different. And even if the seperation would be wanted, I think the right way would be to make the background or the star darker/brighter.

[BeckerWdf]

In my opinion the white filter should be deleted as it looks like an error. I don't think there is a need to seperate the star from the background as the colors are different. And even if the seperation would be wanted, I think the right way would be to make the background or the star darker/brighter.

Agreed.