Toggle OSGi and Eclipse plugin creation options appropriately #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one creates plugins using the automatic manifest generation feature, subsequent plugin projects created with Eclipse as the target is throwing errors, due to the 'Generate OSGi metadata automatically' button not being unchecked. This commit tries to resolve this issue by unchecking the feature whwnever an Eclipse plugin project using templates is created.
Test Results 30 files - 237 30 suites - 237 0s ⏱️ - 48m 21s Results for commit fd68e09. ± Comparison against base commit 27cf508. This pull request removes 3319 tests. |
gireeshpunathil
approved these changes
Oct 13, 2023
|
change looks good, build is failing due to issue mentioned in #782 |
|
I think this is better fixed with: |
laeubi
reviewed
Oct 27, 2023
| @@ -167,6 +167,7 @@ private void updateAutomatic() { | |||
| private void updateRuntimeDependency() { | |||
| boolean depends = fEclipseButton.getSelection(); | |||
| fOSGiCombo.setEnabled(!depends); | |||
| useAutomaticMetadata.setSelection(!depends); | |||
There was a problem hiding this comment.
This seems not very useful as we actually save this so it can be reused afterwards, it would be better to fix the place where having this option active causes trouble.
|
@alshamams I just merged a fix for this can you verify if it solves your problem? In the meanwhile I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one creates plugins using the automatic manifest generation feature,
subsequent plugin projects created with Eclipse as the target is throwing errors, due to the 'Generate OSGi metadata automatically' button not being unchecked. This commit tries to resolve this issue by unchecking the feature whwnever an Eclipse plugin project using templates is created.
Fixes: #798