Make BaseApiAnalyzer#getJavaProject protected #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way to pass the project to the analyzer without having an project ProjectComponent, but users of BaseApiAnalyzer might have other means to find the project in question. This makes the BaseApiAnalyzer#getJavaProject() protected so implementors can override this (e.g. Tycho).
Test Results 273 files + 6 273 suites +6 1h 12m 30s ⏱️ + 23m 18s For more details on these errors, see this check. Results for commit 8981f97. ± Comparison against base commit c9cbfbe. This pull request removes 1 test. |
|
Testfailure is already documented here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to pass the project to the analyzer without having an project ProjectComponent, but users of BaseApiAnalyzer might have other means to find the project in question.
This makes the BaseApiAnalyzer#getJavaProject() protected so implementors can override this (e.g. Tycho).
This relates to