Synchronize Target Node #1534
Merged
Synchronize Target Node #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The org.eclipse.pde.internal.genericeditor.target.extension.model.Node is accessed in a concurrent way but its internal implementation uses unsynchronized mutator methods. This add synchronized to all methods and copy internal datastructures to make the class at least concurrent-safe and prevent unsyncronized data structures to escape the scope of a node.
laeubi
force-pushed
the
syncronize_target_node
branch
from
3eef160 to
0960d93
Compare
|
Only network issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The org.eclipse.pde.internal.genericeditor.target.extension.model.Node is accessed in a concurrent way but its internal implementation uses unsynchronized mutator methods.
This add synchronized to all methods and copy internal datastructures to make the class at least concurrent-safe and prevent unsyncronized data structures to escape the scope of a node.