Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Path instead of URL-String in ClasspathHelper.writeDevEntries() #1530

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

HannesWell
Copy link
Member

Instead returning a file-URL in it's string representation better use the actual type of value, i.e. a Path.

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Dec 19, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

build/org.eclipse.pde.build/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 3e7be3cb8fc1e8e13f33e0617df7d1fedcd30f85 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Thu, 19 Dec 2024 23:04:15 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/build/org.eclipse.pde.build/META-INF/MANIFEST.MF b/build/org.eclipse.pde.build/META-INF/MANIFEST.MF
index a90bb23788..fed4bd6ac6 100644
--- a/build/org.eclipse.pde.build/META-INF/MANIFEST.MF
+++ b/build/org.eclipse.pde.build/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.build;singleton:=true
-Bundle-Version: 3.12.600.qualifier
+Bundle-Version: 3.12.700.qualifier
 Bundle-ClassPath: pdebuild.jar
 Bundle-Activator: org.eclipse.pde.internal.build.BuildActivator
 Bundle-Vendor: %providerName
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Dec 20, 2024

Test Results

   285 files  ±0     285 suites  ±0   52m 59s ⏱️ - 3m 32s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 8221c18. ± Comparison against base commit 1535dde.

♻️ This comment has been updated with latest results.

HannesWell and others added 2 commits December 20, 2024 15:52
Instead returning a file-URL in it's string representation better use
the actual type of value, i.e. a Path.
@akurtakov akurtakov force-pushed the path-instead-url-string branch from 4f523f7 to 8221c18 Compare December 20, 2024 13:52
@akurtakov akurtakov merged commit 0b123e0 into eclipse-pde:master Dec 20, 2024
18 checks passed
@HannesWell HannesWell deleted the path-instead-url-string branch December 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants