-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Launching] Don't add -Djava.security.manager=allow for Java-24 or later #1516
[Launching] Don't add -Djava.security.manager=allow for Java-24 or later #1516
Conversation
Simplify the code and add arguments only if they are not even added with another value.
Since Java-24 the security-manager cannot be used anymore and launching a Java-24 VM fails to launch if the VM-argument '-Djava.security.manager=allow' is specified. Part of eclipse-platform/eclipse.platform.releng.aggregator#2623
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
The complaint about new warnings is a JDT error: Everything else looks good, submitting. |
Actually I wanted to have the first commit submitted as part of #1515, but I confused the tabs... Anyways since this result is equal, that's not a problem. |
Since Java-24 the security-manager cannot be used anymore and launching a Java-24 VM fails to launch if the VM-argument
-Djava.security.manager=allow
is specified.Part of eclipse-platform/eclipse.platform.releng.aggregator#2623
Adn improve addition of default VM arguments for Eclipse apps:
Simplify the code and add arguments only if they are not even added with another value.
CC @merks