Always sort BREE header values in ascending Java version order #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laeubi, @merks what do you think about this? Any objections? As a side note: I just created eclipse-equinox/equinox#655 as an attempt to make the order of some old Java version as expected. But since it only affects old versions I don't consider it a prerequisite. |
HannesWell
force-pushed
the
no-bree-move
branch
2 times, most recently
from
e69ca13 to
ca1196a
Compare
HannesWell
commented
Jul 8, 2024
Comment on lines
111
to
123
| return switch (ee.getId()) { | ||
| // The EE's handled explicitly have unexpected java targets. | ||
| // See https://github.com/eclipse-equinox/equinox/pull/655 | ||
| case "J2SE-1.2" -> 1.2; //$NON-NLS-1$ | ||
| case "J2SE-1.3" -> 1.3; //$NON-NLS-1$ | ||
| case "J2SE-1.4" -> 1.4; //$NON-NLS-1$ | ||
| default -> { | ||
| Properties properties = ee.getProfileProperties(); | ||
| Object target = properties != null // | ||
| ? properties.get(JavaCore.COMPILER_CODEGEN_TARGET_PLATFORM) | ||
| : null; | ||
| yield target instanceof String version ? Double.parseDouble(version) : 0; | ||
| } |
There was a problem hiding this comment.
Just for clarification: This part could probably be simplified to only the default case if eclipse-equinox/equinox#655 were available.
Remove the ability to manually move required execution environments in the Manifest Editor. Instead always sort the values in ascending Java version order. From a technical perspective the order of the values of the 'Bundle-RequiredExecutionEnvironment' header is irrelevant, similar to for example the 'Import-Package' header. Removing the buttons to reorder the values simplifies the UI. Values of existing Plug-in projects are displayed in sorted order regardless of if they are actually sorted in the MANIFEST.MF or not. On the next write all values will be written in sorted order.
|
I'm going to submit this now to unblock #1285, but still hope that eclipse-equinox/equinox#655 can be leveraged later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ability to manually move required execution environments in the Manifest Editor. Instead always sort the values in ascending Java version order.
From a technical perspective the order of the values of the
Bundle-RequiredExecutionEnvironmentheader is irrelevant, similar to for example theImport-Packageheader. Removing the buttons to reorder the values simplifies the UI.Values of existing Plug-in projects are displayed in sorted order regardless of if they are actually sorted in the
MANIFEST.MFor not. On the next write all values will be written in sorted order.With this change applied the EE section now looks like this: