Ticket #1218 solution

eclipse-pde · Nov 16, 2024 · c9977e6 · c9977e6
1 parent ef694eb
commit c9977e6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/...pse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/AnnotationVisitor.java b/...pse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/AnnotationVisitor.java
@@ -258,6 +258,11 @@ public boolean visit(TypeDeclaration type) {
 							if (hasInjectableConstructor) {
 								// TODO we should add an error marker that offers a quickfix to upgrade the spec
 								// version to 1.4
+								problemReporter.reportProblem(annotation, null,
+										NLS.bind(
+												Messages.AnnotationProcessor_invalidCompImplClass_injectableConstructor,
+												type.getName().getIdentifier()),
+										type.getName().getIdentifier());
 							}
 							problemReporter.reportProblem(annotation, null,
 									NLS.bind(Messages.AnnotationProcessor_invalidCompImplClass_noDefaultConstructor,

diff --git a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/Messages.java b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/Messages.java
@@ -47,6 +47,7 @@ public class Messages extends NLS {
 
 	public static String AnnotationProcessor_invalidCompImplClass_noDefaultConstructor;
 
+	public static String AnnotationProcessor_invalidCompImplClass_injectableConstructor;
 	public static String AnnotationProcessor_invalidCompImplClass_notPublic;
 
 	public static String AnnotationProcessor_invalidCompImplClass_notTopLevel;

diff --git a/...clipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/messages.properties b/...clipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/messages.properties
@@ -25,6 +25,7 @@ AnnotationProcessor_invalidCompImplClass_annotation=Invalid component implementa
 AnnotationProcessor_invalidCompImplClass_enumeration=Invalid component implementation class ''{0}'': enumeration type.
 AnnotationProcessor_invalidCompImplClass_interface=Invalid component implementation class ''{0}'': interface type.
 AnnotationProcessor_invalidCompImplClass_noDefaultConstructor=Invalid component implementation class ''{0}'': no default constructor.
+AnnotationProcessor_invalidCompImplClass_injectableConstructor=Invalid component implementation class ''{0}'':  has an injectable constructor that is not public. Please ensure constructor is annotated with @activate.
 AnnotationProcessor_invalidCompImplClass_compatibleConstructor=Invalid component implementation class ''{0}'': no default or @Activate annotated constructor.
 AnnotationProcessor_invalidCompImplClass_notPublic=Invalid component implementation class ''{0}'': not a public class.
 AnnotationProcessor_invalidCompImplClass_notTopLevel=Invalid component implementation class ''{0}'': not a primary class or static class nested in primary type.