Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JFR metadata.blob file #20806

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Update JFR metadata.blob file #20806

merged 1 commit into from
Dec 11, 2024

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Dec 10, 2024

The existing metadata.blob doesnt capture all JFR events. This PR updates blob file used to support more JFR events.

The existing metadata.blob doesnt capture all JFR events. This PR
updates blob file used to support more JFR events.

Signed-off-by: Tobi Ajila <[email protected]>
@tajila
Copy link
Contributor Author

tajila commented Dec 10, 2024

jenkins test sanity.functional xlinux jdk17

@tajila tajila requested a review from babsingh December 10, 2024 20:08
@tajila
Copy link
Contributor Author

tajila commented Dec 10, 2024

@babsingh Please review these changes

@babsingh
Copy link
Contributor

Is the blob file auto-generated?

@tajila
Copy link
Contributor Author

tajila commented Dec 10, 2024

Is the blob file auto-generated?

No, this was manually generated. In the future we will add support to auto generate at runtime.

@babsingh
Copy link
Contributor

Only the hpp file needs to be reviewed since the blob file is generated through a script?

@tajila
Copy link
Contributor Author

tajila commented Dec 10, 2024

yes

@babsingh babsingh merged commit 20b8e7c into eclipse-openj9:master Dec 11, 2024
5 checks passed
@pshipton pshipton added the jfr label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants