Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable-length array warning in clang #20795

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

cjjdespres
Copy link
Contributor

The maxCount parameter is a dynamic quantity, and creating an array of that length in C++ causes a warning-as-error with Clang 18.

The maxCount parameter is a dynamic quantity, and creating an array of
that length in C++ causes a warning-as-error with Clang 18.

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres cjjdespres requested a review from dsouzai as a code owner December 10, 2024 15:23
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu mpirvu self-assigned this Dec 10, 2024
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Dec 10, 2024
@mpirvu
Copy link
Contributor

mpirvu commented Dec 10, 2024

jenkins test sanity xlinuxjit,zlinuxjit,plinuxjit,alinuxjit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 10, 2024

jenkins test sanity xlinuxjit,zlinuxjit,plinuxjit,alinux64jit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 10, 2024

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 10, 2024

vectorAPI tests have failed, but that is expected.

@mpirvu
Copy link
Contributor

mpirvu commented Dec 10, 2024

jenkins test openjdk plinuxjit,alinux64jit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 10, 2024

plinux openjdk tests also fail all VectorAPI cases which is a known issue.
This PR is ready to be merged.

@mpirvu mpirvu merged commit 0f17993 into eclipse-openj9:master Dec 10, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants