Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude testJitserverArguments on xlinux jdk8 #20774

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Dec 6, 2024

Issue #18599

@pshipton pshipton requested a review from llxia December 6, 2024 22:27
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/18599</comment>
<version>8</version>
<platform>x86-64_linux</platform>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to add .* to this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not necessary to have .* in this case. But we do need to wrap this with <disables>...</disables>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 81ab91c into eclipse-openj9:master Dec 7, 2024
2 checks passed
@llxia
Copy link
Contributor

llxia commented Dec 7, 2024

Forgot to provide the Grinder link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants