(0.49) Implement boxing/unboxing during VectorAPIExpansion under an option #20769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce new category of temps: vec_len_boxed_unknown - build temp and whole webs as before - wherever a temp was invalidated before assign vec_len_boxed_unknown instead - store vectorization info for calls per node vs. per symbol reference for temps - always vectorize nodes that are calls to vector API methods, even if input vectors need to be unboxed or result needs to be boxed - since boxing/unboxing is not supported for all types, have an extra pass just before transformation and invalidate whole web if it contains unsupported boxing/unboxing - transformation happens as before, except that we first check if children of non-vectorized node need to be boxed or children of vectorized node need to be unboxed, insert boxing/unboxing correspondingly - this prototype is only enabled under -Xjit:enableVectorAPIBoxing option and the default behaviour shoulld be preserved
|
Original PR: #20685 |
AdamBrousseau
approved these changes
Dec 6, 2024
pshipton
changed the title
pshipton
added this to the Release 0.49 (Java 8, 11, 17, 21, 23) January refresh milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to be unboxed or result needs to be boxed
transformation and invalidate whole web if it contains unsupported boxing/unboxing
node need to be boxed or children of vectorized node need to be unboxed, insert
boxing/unboxing correspondingly
behaviour shoulld be preserved
Backport of #20685