Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLParser: support attributes with empty values #20768

Merged
merged 1 commit into from
Dec 6, 2024
Merged

XMLParser: support attributes with empty values #20768

merged 1 commit into from
Dec 6, 2024

Conversation

keithc-ca
Copy link
Contributor

In #20625, I requested the space be removed from test xml files in places like this:

	<echo value=" "/>

However, the XML parser didn't support empty attribute values:

	<echo value=""/>

This fixes that.

@keithc-ca keithc-ca mentioned this pull request Dec 6, 2024
Merged
@pshipton
Copy link
Member

pshipton commented Dec 6, 2024

https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/4014

@pshipton pshipton merged commit 78500d8 into eclipse-openj9:master Dec 6, 2024
2 checks passed
@keithc-ca keithc-ca deleted the xml branch December 6, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithc-ca @pshipton