OpenJ9 JIT changes to support OMR FrontEnd base class refactoring #20571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity.functional,sanity.openjdk xlinux,plinux,zlinux,alinux jdk21 depends eclipse-omr/omr#7540 This was tested internally across platform, but just doing a quick sniff test here in the PR prior to review. |
|
Z OpenJDK failure appears to be #17955. |
dsouzai
approved these changes
Nov 14, 2024
Signed-off-by: Daryl Maier <[email protected]>
|
Jenkins test sanity.functional xlinux,plinux,zlinux,alinux jdk21 depends eclipse-omr/omr#7540 |
|
@dsouzai : The subset of sanity acceptance testing passed, as well as an internal build on SDK8 that included 32-bit testing. Could you merge the two PRs if you are satisfied please? |
mstoodle
approved these changes
Dec 2, 2024
| #include "codegen/CodeGenerator.hpp" | ||
| #if defined(J9VM_OPT_JITSERVER) | ||
| #include "control/CompilationRuntime.hpp" | ||
| #include "control/CompilationThread.hpp" | ||
| #include "runtime/JITClientSession.hpp" | ||
| #endif /* defined(J9VM_OPT_JITSERVER) */ | ||
|
|
||
| // This is a workaround to avoid J9_PROJECT_SPECIFIC macros in x/env/OMRCPU.cpp | ||
| // Without this definition, we get an undefined symbol of JITConfig::instance() at runtime | ||
| TR::JitConfig * TR::JitConfig::instance() { return NULL; } |
There was a problem hiding this comment.
This one always annoyed me. Glad to see we're finally getting rid of it :) .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking dependence on eclipse-omr/omr#7540 due to file changes.