Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document conditional directives in x/codegen/J9TreeEvaluator.cpp #20470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document conditional directives in x/codegen/J9TreeEvaluator.cpp #20470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 41 additions & 41 deletions runtime/compiler/x/codegen/J9TreeEvaluator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,16 @@

#ifdef TR_TARGET_64BIT
#include "codegen/AMD64PrivateLinkage.hpp"
#endif
#endif /* TR_TARGET_64BIT */
#ifdef TR_TARGET_32BIT
#include "codegen/IA32PrivateLinkage.hpp"
#include "codegen/IA32LinkageUtils.hpp"
#endif
#endif /* TR_TARGET_32BIT */

#ifdef LINUX
#include <time.h>

#endif
#endif /* LINUX */

#define NUM_PICS 3

Expand Down Expand Up @@ -900,7 +900,7 @@ extern void TEMPORARY_initJ9X86TreeEvaluatorTable(TR::CodeGenerator *cg)
tet[TR::d2lu] = TR::TreeEvaluator::d2lEvaluator;
tet[TR::ldiv] = TR::TreeEvaluator::integerPairDivEvaluator;
tet[TR::lrem] = TR::TreeEvaluator::integerPairRemEvaluator;
#endif
#endif /* defined(TR_TARGET_32BIT) */
}


Expand Down Expand Up @@ -1030,7 +1030,7 @@ TR::Register *J9::X86::I386::TreeEvaluator::conditionalHelperEvaluator(TR::Node
cg->decReferenceCount(testNode);
return NULL;
}
#endif
#endif /* TR_TARGET_32BIT */

#ifdef TR_TARGET_64BIT
TR::Register *J9::X86::AMD64::TreeEvaluator::conditionalHelperEvaluator(TR::Node *node, TR::CodeGenerator *cg)
Expand Down Expand Up @@ -1209,14 +1209,14 @@ TR::Register *J9::X86::AMD64::TreeEvaluator::conditionalHelperEvaluator(TR::Node
cg->decReferenceCount(testNode);
return NULL;
}
#endif
#endif /* TR_TARGET_64BIT */

TR::Register* J9::X86::TreeEvaluator::performHeapLoadWithReadBarrier(TR::Node* node, TR::CodeGenerator* cg)
{
#ifndef OMR_GC_CONCURRENT_SCAVENGER
TR_ASSERT_FATAL(0, "Concurrent Scavenger not supported.");
return NULL;
#else
#else /* OMR_GC_CONCURRENT_SCAVENGER */
TR::Compilation *comp = cg->comp();
bool use64BitClasses = comp->target().is64Bit() && !comp->useCompressedPointers();

Expand Down Expand Up @@ -1275,7 +1275,7 @@ TR::Register* J9::X86::TreeEvaluator::performHeapLoadWithReadBarrier(TR::Node* n
}
cg->stopUsingRegister(address);
return object;
#endif
#endif /* OMR_GC_CONCURRENT_SCAVENGER */
}

// Should only be called for pure TR::awrtbar and TR::awrtbari nodes.
Expand Down Expand Up @@ -4980,7 +4980,7 @@ void J9::X86::TreeEvaluator::inlineRecursiveMonitor(
node,
generateX86MemoryReference(vmThreadReg, fej9->thisThreadGetOwnedMonitorCountOffset(), cg),
cg);
#endif
#endif /* defined(TR_TARGET_64BIT) && (JAVA_SPEC_VERSION >= 19) */

TR::RegisterDependencyConditions *restartDeps = generateRegisterDependencyConditions((uint8_t)0, 4, cg);
restartDeps->addPostCondition(objectReg, TR::RealRegister::NoReg, cg);
Expand Down Expand Up @@ -5423,7 +5423,7 @@ J9::X86::TreeEvaluator::VMmonentEvaluator(
node,
generateX86MemoryReference(vmThreadReg, fej9->thisThreadGetOwnedMonitorCountOffset(), cg),
cg);
#endif
#endif /* defined(TR_TARGET_64BIT) && (JAVA_SPEC_VERSION >= 19) */

// Create dependencies for the registers used.
// The dependencies must be in the order:
Expand Down Expand Up @@ -5745,7 +5745,7 @@ J9::X86::TreeEvaluator::VMmonexitEvaluator(
node,
generateX86MemoryReference(vmThreadReg, fej9->thisThreadGetOwnedMonitorCountOffset(), cg),
cg);
#endif
#endif /* defined(TR_TARGET_64BIT) && (JAVA_SPEC_VERSION >= 19) */

// Create dependencies for the registers used.
// The first dependencies must be objectReg, vmThreadReg, tempReg
Expand Down Expand Up @@ -5981,7 +5981,7 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
generateLabelInstruction(TR::InstOpCode::JAE4, node, doneLabel, cg);
generateRegImmInstruction(TR::InstOpCode::MOVRegImm4(), node, segmentReg, J9_GC_MINIMUM_OBJECT_SIZE, cg);
generateLabelInstruction(TR::InstOpCode::label, node, doneLabel, cg);
#endif
#endif /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */

// get size class
generateRegMemInstruction(TR::InstOpCode::LRegMem(),
Expand Down Expand Up @@ -6125,7 +6125,7 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(

// we're done
return;
#endif
#endif /* defined(J9VM_GC_REALTIME) */
}
else
{
Expand All @@ -6141,7 +6141,7 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
heapTop_offset = offsetof(J9VMThread, nonZeroHeapTop);
tlhPrefetchFTA_offset = offsetof(J9VMThread, nonZeroTlhPrefetchFTA);
}
#endif
#endif /* J9VM_GC_NON_ZERO_TLH */
// Load the base of the next available heap storage. This load is done speculatively on the assumption that the
// allocation will be inlined. If the assumption turns out to be false then the performance impact should be minimal
// because the helper will be called in that case. It is necessary to insert this load here so that it dominates all
Expand Down Expand Up @@ -6232,7 +6232,7 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
//
TR::LabelSymbol *loopLabel = generateLabelSymbol(cg);
generateLabelInstruction(TR::InstOpCode::label, node, loopLabel, cg);
#endif
#endif /* !defined(J9VM_GC_THREAD_LOCAL_HEAP) */

if (sizeReg)
{
Expand Down Expand Up @@ -6282,11 +6282,11 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
}
}
else
#endif
#endif /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */
{
#ifdef J9VM_INTERP_FLAGS_IN_CLASS_SLOT
generateRegRegInstruction(TR::InstOpCode::XOR4RegReg, node, tempReg, tempReg, cg);
#endif
#endif /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */


generateRegMemInstruction(
Expand All @@ -6296,9 +6296,9 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
generateX86MemoryReference(
#ifdef J9VM_INTERP_FLAGS_IN_CLASS_SLOT
tempReg,
#else
#else /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */
eaxReal,
#endif
#endif /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */
sizeReg,
TR::MemoryReference::convertMultiplierToStride(elementSize),
allocationSizeOrDataOffset+disp32, cg), cg);
Expand All @@ -6315,7 +6315,7 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
generateRegImmInstruction(TR::InstOpCode::MOVRegImm4(), node, tempReg, J9_GC_MINIMUM_OBJECT_SIZE, cg);
generateLabelInstruction(TR::InstOpCode::label, node, doneLabel, cg);
generateRegRegInstruction(TR::InstOpCode::ADDRegReg(), node, tempReg, eaxReal, cg);
#endif
#endif /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */
}
}
else
Expand Down Expand Up @@ -6388,7 +6388,7 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
{
prefetchThunkGenerated = (fej9->getAllocationNoZeroPrefetchCodeSnippetAddress(comp) !=0);
}
#endif
#endif /* J9VM_GC_NON_ZERO_TLH */
if (useSharedCodeCacheSnippet && prefetchThunkGenerated)
{
useDirectPrefetchCall = true;
Expand Down Expand Up @@ -6416,19 +6416,19 @@ static void genHeapAllocForDiscontiguousArraysOrRealtime(
{
helperSymbol->setMethodAddress(fej9->getAllocationPrefetchCodeSnippetAddress(comp));
}
#else
#else /* J9VM_GC_NON_ZERO_TLH */
helperSymbol->setMethodAddress(fej9->getAllocationPrefetchCodeSnippetAddress(comp));
#endif
#endif /* J9VM_GC_NON_ZERO_TLH */
generateImmSymInstruction(TR::InstOpCode::CALLImm4, node, (uintptr_t)helperSymbol->getMethodAddress(), helperSymRef, cg);
}

generateLabelInstruction(TR::InstOpCode::label, node, restartLabel, cg);
}

#else // J9VM_GC_THREAD_LOCAL_HEAP
#else /* defined(J9VM_GC_THREAD_LOCAL_HEAP) */
generateMemRegInstruction(TR::InstOpCode::CMPXCHGMemReg(), node, generateX86MemoryReference(vmThreadReg, heapAlloc_offset, cg), tempReg, cg);
generateLabelInstruction(TR::InstOpCode::JNE4, node, loopLabel, cg);
#endif // !J9VM_GC_THREAD_LOCAL_HEAP
#endif /* defined(J9VM_GC_THREAD_LOCAL_HEAP) */
}
}

Expand Down Expand Up @@ -6721,9 +6721,9 @@ static void genInitObjectHeader(TR::Node *node,
generateX86MemoryReference(objectReg, TMP_OFFSETOF_J9OBJECT_FLAGS, cg),
orFlags, cg);

#endif /* !J9VM_OPT_NEW_OBJECT_HASH */
#endif /* defined(J9VM_OPT_NEW_OBJECT_HASH) */
}
#endif /* FLAGS_IN_CLASS_SLOT */
#endif /* J9VM_INTERP_FLAGS_IN_CLASS_SLOT */

// --------------------------------------------------------------------------------
//
Expand Down Expand Up @@ -7092,7 +7092,7 @@ static bool genZeroInitForEntireObjectOrHybridArraylet(
}
else
{
#endif
#endif /* TR_TARGET_64BIT */
// Begin zero initialization after the header
//
generateRegMemInstruction(
Expand Down Expand Up @@ -7123,7 +7123,7 @@ static bool genZeroInitForEntireObjectOrHybridArraylet(
}
#ifdef TR_TARGET_64BIT
}
#endif
#endif /* TR_TARGET_64BIT */

return true;
}
Expand Down Expand Up @@ -7837,7 +7837,7 @@ J9::X86::TreeEvaluator::VMnewEvaluator(
if (comp->getOption(TR_TraceCG))
traceMsg(comp, "NOSKIPZEROINIT: for %p, keep symbol as %p ", node, node->getSymbolReference());
}
#endif
#endif /* J9VM_GC_NON_ZERO_TLH */

segmentReg = srm->findOrCreateScratchRegister();
tempReg = srm->findOrCreateScratchRegister();
Expand Down Expand Up @@ -7906,7 +7906,7 @@ J9::X86::TreeEvaluator::VMnewEvaluator(
#ifdef J9VM_GC_NON_ZERO_TLH
if (!enableTLHBatchClearing || realTimeGC)
{
#endif
#endif /* J9VM_GC_NON_ZERO_TLH */
if (!maxZeroInitWordsPerIteration)
{
static char *p = feGetEnv("TR_MaxZeroInitWordsPerIteration");
Expand Down Expand Up @@ -8074,7 +8074,7 @@ J9::X86::TreeEvaluator::VMnewEvaluator(
monitorSlotIsInitialized = false;
useRepInstruction = false;
}
#endif
#endif /* J9VM_GC_NON_ZERO_TLH */

// --------------------------------------------------------------------------------
// Initialize the header
Expand Down Expand Up @@ -8839,7 +8839,7 @@ addFPXMMDependencies(
}
}
}
#endif
#endif /* defined(TR_TARGET_32BIT) */

#define J9TIME_NANOSECONDS_PER_SECOND ((I_64) 1000000000)
#if defined(TR_TARGET_64BIT)
Expand Down Expand Up @@ -8935,7 +8935,7 @@ inlineNanoTime(
return false;
}
}
#else // !64bit
#else /* defined(TR_TARGET_64BIT) */
static bool
inlineNanoTime(
TR::Node *node,
Expand Down Expand Up @@ -9123,8 +9123,8 @@ inlineNanoTime(

return true;
}
#endif
#endif // LINUX
#endif /* defined(TR_TARGET_64BIT) */
#endif /* LINUX */

// Convert serial String.hashCode computation into vectorization copy and implement with SSE instruction
//
Expand Down Expand Up @@ -9593,7 +9593,7 @@ static TR::Register* inlineCompareAndSwapObjectNative(TR::Node* node, TR::CodeGe
TR_ASSERT(false, "Unsupported Read Barrier Type.");
break;
}
#endif
#endif /* defined(OMR_GC_CONCURRENT_SCAVENGER) */

generateRegRegInstruction(TR::InstOpCode::MOVRegReg(), node, EAX, oldValue, cg);
generateRegRegInstruction(TR::InstOpCode::MOVRegReg(), node, tmp, newValue, cg);
Expand Down Expand Up @@ -10155,7 +10155,7 @@ bool J9::X86::TreeEvaluator::VMinlineCallEvaluator(
callWasInlined = inlineNanoTime(node, cg);
break;
}
#endif
#endif /* LINUX */
default:
break;
}
Expand Down Expand Up @@ -11634,7 +11634,7 @@ J9::X86::TreeEvaluator::directCallEvaluator(TR::Node *node, TR::CodeGenerator *c
{
return returnRegister;
}
#endif
#endif /* J9VM_OPT_JAVA_CRYPTO_ACCELERATION */

if (symbol->isHelper())
{
Expand Down Expand Up @@ -13258,7 +13258,7 @@ void J9::X86::I386::TreeEvaluator::lStoreEvaluatorSetHighLowMRIfNeeded(TR::Node
}
}
}
#endif
#endif /* TR_TARGET_32BIT */

#ifdef TR_TARGET_64BIT
TR::Register *J9::X86::AMD64::TreeEvaluator::dwrtbarEvaluator(TR::Node *node, TR::CodeGenerator *cg)
Expand Down Expand Up @@ -13302,7 +13302,7 @@ TR::Register *J9::X86::AMD64::TreeEvaluator::dwrtbariEvaluator(TR::Node *node, T
cg->decReferenceCount(sideEffectNode);
return TR::TreeEvaluator::floatingPointStoreEvaluator(node, cg);
}
#endif
#endif /* TR_TARGET_64BIT */

TR::Register *J9::X86::TreeEvaluator::awrtbariEvaluator(TR::Node *node, TR::CodeGenerator *cg)
{
Expand Down