Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Valhalla Jtreg StrictFields test #20399

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

theresa-m
Copy link
Contributor

  • Only recognize strict field for valuetype class versions
  • Remove outdated value type field verification checks (@hangshao0 can you confirm this? I wasn't able to track down what draft spec these were part of and I can't find anything in the latest version)

Related to #19830 and #13182

@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Oct 23, 2024
runtime/bcutil/cfreader.c Outdated Show resolved Hide resolved
runtime/bcutil/cfreader.c Show resolved Hide resolved
runtime/bcverify/vrfyhelp.c Outdated Show resolved Hide resolved
@theresa-m theresa-m force-pushed the fix_jtreg_StrictFields branch from c58e548 to d0ee396 Compare October 24, 2024 16:08
@theresa-m theresa-m requested a review from hangshao0 October 24, 2024 16:09
runtime/oti/j9.h Outdated Show resolved Hide resolved
@theresa-m theresa-m force-pushed the fix_jtreg_StrictFields branch from d0ee396 to 4715350 Compare October 25, 2024 14:21
@theresa-m theresa-m requested a review from hangshao0 October 25, 2024 14:21
@hangshao0
Copy link
Contributor

Jenkins test sanity.functional,extended alinuxval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity.functional,extended xlinuxval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity.functional,extended alinuxval jdknext

@hangshao0 hangshao0 merged commit 6544c13 into eclipse-openj9:master Oct 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants